Hi Emilio, On Wed, Mar 10, 2010 at 07:46:17PM +0100, Emilio Pozuelo Monfort wrote:
I'm writing a python-autotools.mk class.
Quite interesting!I wrote such class a couple of years ago but only 5 hours ago I got around to include in in mainline cdbs.
I am curious both how you implemented your class (maybe you took care of some parts that I missed out?) and also I wonder why it fails with the current class hierarchy.
So... Would you mind sharing that class of yours?My implementation is in Git: http://git.debian.org/?p=collab-maint/cdbs.git;a=blob;f=1/class/python-autotools.mk.in
I've included autotools-vars.mk from it to get all the variables I need to use, but autotools-vars.mk includes makefile.mk and that breaks my class.I think autotools-vars.mk should only include makefile-vars.mk, and the stuff that really needs makefile.mk (e.g. autotools.mk or autotools-files.mk) should include it directly.Here's a patch that does that. It builds fine (i.e. it passes the test suite) and lets me include autotools-vars.mk.
The test suite only covers a small fraction of possible CDBS use cases.I have wondered myself why autotools-vars included makefile and not just makefile-vars. It was done like that before I got heavily involved with CDBS, but I suspect it was due to order of inclusion - which I believe has been solved since then.
Nevertheless there might be users reying on that dependency by now :-/So please, share your code and let's see what is the problem there - perhaps it can enlighten me of some common problem that others might run into which is relevant to fix, even if your class might not be needed now that there's an alternative implementation available.
Regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
