tags 561038 + upstream moreinfo
thanks
Ximin Luo wrote:
> Version: 1:1.6.5-1
> Severity: normal
> Tags: patch
>
> The "project search" form on the front ("project list") page of gitweb
> defaults
> to pointing to "http://localhost";. This is because the call to $cgi->startform
> on line 4584 has no "action" parameter. This is fixed by adding the parameter
> so that it matches the other call to $cgi->startform, on line 3170. (The local
> $action variable is equal to the global $my_uri variable.)
[...]
> --- gitweb.cgi.old 2009-12-13 23:03:13.000000000 +0000
> +++ gitweb.cgi 2009-12-13 23:01:02.000000000 +0000
> @@ -4584,7 +4584,7 @@
> insert_file($home_text);
> print "</div>\n";
> }
> - print $cgi->startform(-method => "get") .
> + print $cgi->startform(-method => "get", -action => $my_uri) .
> "<p class=\"projsearch\">Search:\n" .
> $cgi->textfield(-name => "s", -value => $searchtext) . "\n" .
> "</p>" .
Sorry to leave this hanging for so long. I am having trouble
reproducing your bug. I tried:
1. Install the gitweb package for Debian, version 1.7.0-1
2. ln -s /tmp/test-repo/.git /var/cache/git/foo.git
3. Visit http://localhost/gitweb/
4. Type foo into the search box and hit enter.
The result was
http://localhost/gitweb/?s=foo
rather than http://localhost/?s=foo as I expected from your message.
On the other hand, I do see the inconsistency you are pointing out:
the search within a project defined in gitweb/gitweb.perl line 3306
has an -action parameter, while the project search on line 4822 does
not. I just don’t know enough about gitweb to tell whether this
matters.
Could you try again and let me know how it goes? If you are sure this
is a reproducible problem (as in, it breaks with the new standard
configuration or you are sure your configuration is correct), then
please report it to the git list at g...@vger.kernel.org and CC
Petr Baudis <pa...@suse.cz>, Jakub Narebski <jna...@gmail.com>, and me.
Thanks for the report,
Jonathan
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
