tags 475853 + patch thanks [Filipus Klutiero 2008-04-13] > klash's menu item uses Exec=/usr/bin/klash. klash without arguments > just outputs usage help, so the menu item does nothing. I never > tried klash before and don't know if it already worked, but AFAICS > this menu item should simply be removed. > gnash seems to have the same problem.
I suspect you are right, but there might be a reason to keep the desktop files. I am not sure, but suspect at least Gnome and KDE uses the mime type setting to know which programs to use for a given content type. If that is true, the desktop files should be kept (I do not know much about desktop files, so I might be mistaken). I notice the gnash and klash desktop files differ a bit. I suspect the klash file should be brought in line with the gnash one, which include %U as an argument for the command (without hard coded path), include mime types and set nodisplay=true. Also, it have a bit more info in the Categories field. I propose this patch to make the klash desktop file more useful, assuming my analysis above is correct. diff -ur gnash-0.8.7/debian/klash.desktop.in gnash-0.8.7-pere/debian/klash.desktop.in --- gnash-0.8.7/debian/klash.desktop.in 2010-02-25 22:46:46.000000000 +0100 +++ gnash-0.8.7-pere/debian/klash.desktop.in 2010-02-25 22:48:05.000000000 +0100 @@ -5,6 +5,8 @@ GenericName= Comment= Icon=gnash -Exec=/usr/bin/klash +Exec=klash %U Terminal=false -Categories=AudioVideo;Player;KDE; +Categories=AudioVideo;Video;Player;KDE; +MimeType=application/x-shockwave-flash;application/futuresplash; +NoDisplay=true With the patch in place, the difference between the two desktop files look like this: --- debian/gnash.desktop.in 2010-02-25 22:47:02.000000000 +0100 +++ debian/klash.desktop.in 2010-02-25 22:48:05.000000000 +0100 @@ -1,12 +1,12 @@ [Desktop Entry] Type=Application Encoding=UTF-8 -_Name=Gnash SWF Viewer +_Name=Gnash SWF Viewer for KDE GenericName= Comment= Icon=gnash -Exec=gnash %U +Exec=klash %U Terminal=false -Categories=AudioVideo;Video;Player;GTK; +Categories=AudioVideo;Video;Player;KDE; MimeType=application/x-shockwave-flash;application/futuresplash; NoDisplay=true Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
