forwarded 569548 ontforge-de...@lists.sourceforge.net
thanks
--- Begin Message ---
Package: fontforge
Version: 0.0.20090923-1+b1
Severity: normal
At line scstyles.c:2676, we test if sc_sc == NULL and then jump to
end_loop2.
But at end_loop2 (sctyles.c:2725), we dereference sc and this gives us a
nice segfault. Skipping the dereference at that point means that we
don't update the UI for that point (which should not be updated anyway,
since nothing was converted to small caps).
This patch only allows the dereference of the pointer if it is non-NULL.
This has been applied, compiled, tested and successfully used to
generate a preliminary version of Utopia with small caps.
Please, be warned that the result of running fontforge under valgrind is
quite scary regarding the memory management.
Regards, Rogério Brito.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.33-rc5-00237-g9a3cbe3 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.utf-8, LC_CTYPE=pt_BR.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages fontforge depends on:
ii libc6 2.10.2-6 Embedded GNU C Library: Shared lib
ii libcairo2 1.8.8-2 The Cairo 2D vector graphics libra
ii libfontconfig1 2.8.0-2 generic font configuration library
ii libfontforge1 0.0.20090923-1+b1 font editor - runtime library
ii libfreetype6 2.3.11-1 FreeType 2 font engine, shared lib
ii libgdraw4 0.0.20090923-1+b1 font editor - runtime graphics and
ii libgif4 4.1.6-9 library for GIF images (library)
ii libglib2.0-0 2.22.4-1 The GLib library of C routines
ii libice6 2:1.0.6-1 X11 Inter-Client Exchange library
ii libjpeg62 6b-16.1 The Independent JPEG Group's JPEG
ii libpango1.0-0 1.26.2-1 Layout and rendering of internatio
ii libpng12-0 1.2.42-2 PNG library - runtime
ii libsm6 2:1.1.1-1 X11 Session Management library
ii libspiro0 20071029-2 a library for curve design
ii libtiff4 3.9.2-3+b1 Tag Image File Format (TIFF) libra
ii libuninameslist0 0.0.20091231-1 a library of Unicode annotation da
ii libx11-6 2:1.3.3-1 X11 client-side library
ii libxft2 2.1.14-1 FreeType-based font drawing librar
ii libxml2 2.7.6.dfsg-2+b1 GNOME XML library
ii python2.5 2.5.5-2 An interactive high-level object-o
ii zlib1g 1:1.2.3.4.dfsg-3 compression library - runtime
fontforge recommends no packages.
Versions of packages fontforge suggests:
pn autotrace <none> (no description available)
pn fontforge-doc <none> (no description available)
ii fontforge-extras 0.3-1 Additional data and utilities for
pn potrace <none> (no description available)
pn python-fontforge <none> (no description available)
-- no debconf information
--
Rogério Brito : rbr...@{ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
--- a/fontforge/scstyles.c
+++ b/fontforge/scstyles.c
@@ -2723,9 +2723,11 @@
SCCharChangedUpdate(sc_sc,fv->active_layer);
}
end_loop2:
- if ( !sc->ticked && !ff_progress_next())
- break;
- sc->ticked = true;
+ if (sc) {
+ if ( !sc->ticked && !ff_progress_next())
+ break;
+ sc->ticked = true;
+ }
}
}
}
--- End Message ---
