On Thu, Feb 04, 2010 at 07:19:23PM +0100, Philipp Kern wrote: > I'm ok with using a Perl interpreter to determine from Packages-arch-specific > (which is small compared to a Packages file) if an architecture is in a > wildcarded list. However in the critical path it feels wrong. Did you > already measure the impact of your patch? Just take one Packages file from > unstable and a Sources file and run quinn-diff with and without your patch.
Ok, it doesn't look that much slower. I produced a preliminary patch on [1], based on yours. It's in the dpkg-perl branch of the repository. We have some cases where we don't want that behaviour, see the patches to parse_sources.c for that. Furthermore it revealed that it used to check ":" against the current architecture, so we managed to find yet another bug through this change (see [2]). ;-) Kind regards, Philipp Kern [1] http://git.debian.org/?p=buildd-tools/quinn-diff.git;a=commitdiff;h=0a27594680caf998a31cc89da9767d45292d2de4 [2] http://git.debian.org/?p=buildd-tools/quinn-diff.git;a=commitdiff;h=41ee93c0616023fb79f5b1961560ecbac402c418
signature.asc
Description: Digital signature
