tag 564425 + patch thanks On Sat, 09 Jan 2010 13:09:57 +0100, hstuebner wrote:
> I replaced workblockdevicepath with pc->buildplace in the qemubuilder code > to use the mount point to umount. With this fix qemubuilder works again. I stumbled across the same problem, and the change seems to work for me. Junichi: I'm attaching a patch for your convenience (please ignore the NMU parts in the changelog, I just lazily called "dch --nmu"). Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- NP: R.E.M.: Ignoreland
diff -Nru cowdancer-0.60/debian/changelog cowdancer-0.60+nmu1/debian/changelog
--- cowdancer-0.60/debian/changelog 2009-12-02 15:14:33.000000000 +0100
+++ cowdancer-0.60+nmu1/debian/changelog 2010-01-22 15:44:29.000000000 +0100
@@ -1,3 +1,12 @@
+cowdancer (0.60+nmu1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fix "qemubuilder --create fails to start qemu - umount problem": replace
+ workblockdevicepath with pc->buildplace to use the mount point to umount,
+ hint from Heiko Stuebner (closes: #564425).
+
+ -- gregor herrmann <gre...@debian.org> Fri, 22 Jan 2010 15:44:27 +0100
+
cowdancer (0.60) unstable; urgency=low
* cowbuilder: output a more helpful error message when flock/fchmod/fchown is
diff -Nru cowdancer-0.60/qemubuilder.c cowdancer-0.60+nmu1/qemubuilder.c
--- cowdancer-0.60/qemubuilder.c 2009-11-29 11:26:13.000000000 +0100
+++ cowdancer-0.60+nmu1/qemubuilder.c 2010-01-22 15:44:24.000000000 +0100
@@ -470,7 +470,7 @@
system(hostcommand1);
}
- loop_umount(workblockdevicepath);
+ loop_umount(pc->buildplace);
asprintf(&cowdevpath, "%s.cowdev", pc->buildplace);
ret=forkexeclp("qemu-img", "qemu-img",
@@ -503,7 +503,7 @@
printf("running host command: %s\n", hostcommand2);
system(hostcommand2);
}
- loop_umount(workblockdevicepath);
+ loop_umount(pc->buildplace);
rmdir(pc->buildplace);
printf(" -> clean up COW device files\n");
unlink(workblockdevicepath);
@@ -754,7 +754,7 @@
/* TODO: hooks probably need copying here. */
/* TODO: recover aptcache */
- loop_umount(workblockdevicepath);
+ loop_umount(pc->buildplace);
rmdir(pc->buildplace);
// this will have wrong time. how to workaround?
signature.asc
Description: Digital signature
