Package: pidgin-libnotify
Version: 0.14-3
Severity: normal

It is not necessary to use libindicate. The problem is caused by
pidgin-libnotify adding Show button to all notifications.

I have attached a patch that makes the plugin add the button only if
notification server supports actions. I hope it is in appropriate format.


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=cs_CZ.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pidgin-libnotify depends on:
ii  libatk1.0-0             1.28.0-1         The ATK accessibility toolkit
ii  libc6                   2.10.2-5         Embedded GNU C Library: Shared lib
ii  libcairo2               1.8.8-2          The Cairo 2D vector graphics libra
ii  libdbus-1-3             1.2.16-2         simple interprocess messaging syst
ii  libdbus-glib-1-2        0.82-2           simple interprocess messaging syst
ii  libfontconfig1          2.8.0-2          generic font configuration library
ii  libfreetype6            2.3.11-1         FreeType 2 font engine, shared lib
ii  libglib2.0-0            2.22.3-2         The GLib library of C routines
ii  libgtk2.0-0             2.18.5-1         The GTK+ graphical user interface 
ii  libnotify1 [libnotify1- 0.4.5-1          sends desktop notifications to a n
ii  libpango1.0-0           1.26.2-1         Layout and rendering of internatio
ii  pidgin                  2.6.5-1          graphical multi-protocol instant m
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

pidgin-libnotify recommends no packages.

pidgin-libnotify suggests no packages.

-- no debconf information
--- src/pidgin-libnotify.c.old  2008-12-14 18:45:51.000000000 +0100
+++ src/pidgin-libnotify.c      2010-01-12 21:35:24.000000000 +0100
@@ -317,7 +317,11 @@
 
        notify_notification_set_urgency (notification, NOTIFY_URGENCY_NORMAL);
 
-       notify_notification_add_action (notification, "show", _("Show"), 
action_cb, NULL, NULL);
+  GList *caps;
+  caps = notify_get_server_caps();
+  if (g_list_index(caps, "action") != -1) {
+    notify_notification_add_action (notification, "show", _("Show"), 
action_cb, NULL, NULL);
+  }
 
        if (!notify_notification_show (notification, NULL)) {
                purple_debug_error (PLUGIN_ID, "notify(), failed to send 
notification\n");

Reply via email to