On Mon, Jan 11, 2010 at 12:35:08PM +0100, Patrick Schoenfeld wrote:
> On Sat, Jan 09, 2010 at 05:15:30PM +0200, Tommi Vainikainen wrote:
> > Here is a patch that adds simple check for existance of Sources files
> > for each component.
> 
> Thanks, but I for one won't accept that patch in this way. The
> sources files are a requirement to fulfill the job of build-rdeps.
> If they are not around an error should be triggered. This patch
> would simply hide it.
> 
> I could accept one or both of the following solutions:
> 1. In the manpage emphasize that the system requires sources files for
> each component it checks and that the default is to check the given
> common components.
> 2. Add a more speaking warning if the required files are not found,
> before trying to scan the files.

It's quite common to not have either of contrib or non-free in one's
sources.list.  I think improving build-rdeps to handle those situations
in such a way that it prints an informative message is more useful than
the current situation.  There's no reason for us to be invoking
grep-dctrl when we know, from a simple file existence check, that it
will fail.

-- 
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <james...@debian.org>

Attachment: signature.asc
Description: Digital signature

Reply via email to