On Sun, 2010-01-10 at 15:14 -0500, Trond Myklebust wrote: 
> On Sat, 2010-01-09 at 04:38 +0000, Aníbal Monsalve Salazar wrote: 
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563971
> > 
> > rpcbind only enables the -w option if the --enable-warmstarts
> > option is passed to configure.
> > 
> > The fact that it does not print a useful error message in this
> > case is an error.
> > 
> > Signed-off-by: sacrificial-spam-addr...@horizon.com
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Errr.... That is nowhere near anything like a valid signoff.
> 
> The whole point of a signoff line is to let us know who is contributing
> the patch, and that the person in question either wrote the patch
> themselves, or have been given the right to pass it on as an open source
> patch by the true author.
> 
> Big NACK until that is fixed.
> 
> Trond
> 
> > Tested-by: Anibal Monsalve Salazar <ani...@debian.org>

BTW: Since you are passing on the patch to us on behalf of whoever the
true author is, it should really contain a signed-off line from you too.

Cheers
  Trond




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to