Hi Modestas,
I just see you have uploaded amarok for stable to fix the wiki tab, but the
fix you have applied is no longer sufficient to find most artists.
Besides the technical change, they've also changed the standard for naming
pages. It used to be "<artist name> (band)", but now it is just "<artist
name>". The result is that in most cases you'll now get the "article not
found" page.
I'm running a custom version with the attached patch that fixes both
issues. You may want to consider updating your stable upload with that.
Cheers,
FJP
diff -u amarok-1.4.10/debian/changelog amarok-1.4.10/debian/changelog
--- amarok-1.4.10/debian/changelog
+++ amarok-1.4.10/debian/changelog
@@ -1,3 +1,9 @@
+amarok (1.4.10-3~fjp) UNRELEASED; urgency=low
+
+ * Fix display of artist/album info from wikipedia.com.
+
+ -- Frans Pop <f...@debian.org> Thu, 30 Apr 2009 02:48:24 +0200
+
amarok (1.4.10-2) unstable; urgency=high
* Add 20_security_audible_tags.diff patch to fix integer overflow while
only in patch2:
unchanged:
--- amarok-1.4.10.orig/amarok/src/contextbrowser.cpp
+++ amarok-1.4.10/amarok/src/contextbrowser.cpp
@@ -3590,9 +3590,10 @@
QString
ContextBrowser::wikiArtistPostfix() const
{
- if( wikiLocale() == "en" )
- return " (band)";
- else if( wikiLocale() == "de" )
+ //if( wikiLocale() == "en" )
+ // return " (band)";
+ //else if( wikiLocale() == "de" )
+ if( wikiLocale() == "de" )
return " (Band)";
else
return "";
@@ -4189,7 +4190,7 @@
}
// Ok lets remove the top and bottom parts of the page
- m_wiki = m_wiki.mid( m_wiki.find( "<h1 class=\"firstHeading\">" ) );
+ m_wiki = m_wiki.mid( m_wiki.find( "<h1 id=\"firstHeading\" class=\"firstHeading\">" ) );
m_wiki = m_wiki.mid( 0, m_wiki.find( "<div class=\"printfooter\">" ) );
// Adding back license information
m_wiki += copyright;
