On Sun, Dec 06, 2009 at 04:53:33AM +0100, Cyril Brulebois wrote: > firstly, I'm aware of #529281, and I believe this might be different. > > I really don't see why the resulting distribution should be “unstable” > when one uses: > $ sbuild -c experimental-amd64-sbuild -s -A foo.dsc > > And when: > - the chroot name is experimental-… > - the chroot setup says nothing about unstable or sid[1]. > - the distribution is set to experimental (which is ignored, which is > the subject of #529281, if I understood it correctly). > > So, WTH setting the distribution to “unstable”? Looks like I've got 30+ > packages in the wrong distribution now. Not good. Really not. > > If you really want to force people setting (manually) the distribution, > just refuse to proceed if no distribution was specified. > > The current behaviour sounds insane to me, hence this RC bug.
Currently, the reason why your uploads default to unstable is because sbuild defaults to unstable unless you override it. I think the safest solution here is to simply not set it by default, and require the user to always specify it (or set it in their .sbuildrc). This is pretty much exactly the same chicken-and-egg problem as #529281: we don't know the package distribution until we download and unpack it, and we need to do this inside the chroot environment, but we can't know which one to use. - the chroot name is immaterial since one may name them anything you like (and indeed use unstable chroots for experimental building). If you specify a chroot with -c, we can't infer the distribution name from this. - we can, however, infer the chroot from the distribution, though -c can override the default chroot name. - we could add a distribution=… or sbuild-distribution parameter to schroot to allow chroot->distribution inference to work robustly, but I'd rather keep sbuild- specific hacks out of schroot unless unavoidable. If this makes sense and you are OK with it, I'll remove the distribution=unstable default from sbuild. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature