tags 559165 + fixed-upstream pending
thanks

Hello, and thanks for the bug report.

Gábor Gombás <[email protected]> writes:
> I've found the following problems in the new munin-node package:
>
> - Someone tried to use shell-style variable expansion in the
>   postfix_mailstats plugin, which is a perl script:
>
> --- /usr/share/munin/plugins/postfix_mailstats.orig   2009-11-30 
> 18:21:49.000000000 +0100
> +++ /usr/share/munin/plugins/postfix_mailstats        2009-12-02 
> 13:02:54.000000000 +0100
> @@ -51,7 +51,7 @@
>  
>  =cut
>  
> -my $statefile = "$MUNIN_PLUGSTATE/munin-plugin-postfix_mailstats.state";
> +my $statefile = $ENV{'MUNIN_PLUGSTATE'} . 
> "/munin-plugin-postfix_mailstats.state";
>  my $pos;
>  my $delivered = 0;
>  my $rejects = {};

(something like) this is committed upstream already.  There'll be a
1.4.1 release soon, so fixing this with a patch in 1.4.0-2 may not be
needed.

> - munin-node complains about unknown user '(postfix)':
>
> --- /etc/munin/plugin-conf.d/munin-node       (revision 153)
> +++ /etc/munin/plugin-conf.d/munin-node       (working copy)
> @@ -76,7 +76,7 @@
>  
>  
>  [postfix_mailqueue]
> -user (postfix)
> +user postfix
>  
>  [postfix_mailstats]
>  group adm

Fixed in the debian packaging repo

According to http://munin-monitoring.org/wiki/plugin-conf.d, parens are
allowed around groups only, and will allow the plugin to run if the
group does not exist.

Is this a syntax change from 1.2 to 1.4?

> - the ipmi_* plugins need to run as root because:
>
> # ls -l /dev/ipmi0 
> crw-rw---- 1 root root 248, 0 2009-07-23 17:54 /dev/ipmi0
>
>   so I suggest adding
>
>       [ipmi_*]
>       user root
>
>   to /etc/munin/plugin-conf.d/munin-node

Fixed in the debian packaging repo

-- 
Stig Sandbeck Mathisen



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to