Hi. ERSEK Laszlo <la...@caesar.elte.hu> (01/12/2009): > Oh thank you for your kind words. Firstly, strerror() is not > required to be reentrant by SUSv2 [0], which is the one and only > standard that lbzip2 is coded against. Secondly, incredible it might > seem, I even know about strerror_r(), and if you grep the source for > it, you'll find that I deliberately avoided it, since it first > appeared in SUSv3 [1]. I do call err2str() from multiple threads in > parallel. It's not nice but portable and gets the work done.
Then you might want to document this somewhere like in a comment around that part of the code? That might lead people to think you actually got a clue about what you're doing. “Logging utilities (that can be called/accessed from multiple threads)” doesn't really tell anything about SUSv2 vs. SUSv3. Incredible it might seem, there is a lot of shitty code in the archive, assuming the worse is usually the way to go. > Wrt. to the compilation error itself: this is a > standards-non-compliance bug in GNU/kFreeBSD; SUSv2 mandates those > STREAMS related error numbers [2] [3]. I'm not saying GNU/kFreeBSD > should support STREAMS, but it should #define those macros. (Or > maybe GNU/kFreeBSD doesn't even intend to support SUSv2; in that > case, all bets are off and we're in hack-land.) I'll try and keep an eye on this, and raise it on debian-...@. > Thanks for reporting, but please don't assume I'm *this* > stupid. Even if I am, I'm not sure I'd deserve those "reinventing > the weel" words, esp. in public. I'm sorry to have hurt your feelings. FWIW, the new version built just fine. Mraw, KiBi.
signature.asc
Description: Digital signature
