Package: libsvm2-java
Version: 
Severity: important
Tags: patch

libsvm2-java installs the pre-built java/libsvm.jar instead of
rebuilding it. Since the source is there this is probably no policy
violation but it's still Not The Right Thing [tm].

Fortunately it's easy to fix; find attached a quick patch. Probably
debian/deb-python.diff should be renamed. And note that the changes
to the clean target in Makefile don't work because the patch is not
applied at that time (this is not new, and I'm lacking CDBS foo to
fix this issue).

Cheers,
gregor, from the Munich BSP

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
   `-    BOFH excuse #99:  SIMM crosstalk. 
diff -u libsvm-2.89/debian/control libsvm-2.89/debian/control
--- libsvm-2.89/debian/control
+++ libsvm-2.89/debian/control
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Chen-Tse Tsai <ctse.t...@gmail.com>
 XS-Python-Version: >= 2.4
-Build-Depends: debhelper (>= 5.0.0), autotools-dev, libtool, cdbs, python-all-dev, python-central (>= 0.5), swig, quilt (>= 0.40)
+Build-Depends: debhelper (>= 5.0.0), autotools-dev, libtool, cdbs, python-all-dev, python-central (>= 0.5), swig, quilt (>= 0.40), default-jdk-builddep
 Standards-Version: 3.8.0
 Homepage: http://www.csie.ntu.edu.tw/~cjlin/libsvm/
 
diff -u libsvm-2.89/debian/changelog libsvm-2.89/debian/changelog
--- libsvm-2.89/debian/changelog
+++ libsvm-2.89/debian/changelog
@@ -1,3 +1,10 @@
+libsvm (2.89-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Rebuild .jar from source.
+
+ -- gregor herrmann <gre...@debian.org>  Sun, 29 Nov 2009 12:02:00 +0100
+
 libsvm (2.89-1) unstable; urgency=low
 
   * New upstream release.
diff -u libsvm-2.89/debian/patches/deb-python.diff libsvm-2.89/debian/patches/deb-python.diff
--- libsvm-2.89/debian/patches/deb-python.diff
+++ libsvm-2.89/debian/patches/deb-python.diff
@@ -1,8 +1,6 @@
-Index: libsvm-2.89/Makefile
-===================================================================
---- libsvm-2.89.orig/Makefile	2009-03-16 12:12:16.000000000 +0800
-+++ libsvm-2.89/Makefile	2009-03-16 12:14:07.000000000 +0800
-@@ -1,19 +1,46 @@
+--- a/Makefile
++++ b/Makefile
+@@ -1,19 +1,50 @@
 -CXX? = g++
 -CFLAGS = -Wall -Wconversion -O3 -fPIC
 -SHVER = 1
@@ -30,12 +28,16 @@
 +LIBFILE=$(LIBNAME).$(SOVER)
 +
 +
-+all: svm-train svm-predict svm-scale $(LIBNAME) .pystuff
++all: svm-train svm-predict svm-scale $(LIBNAME) .pystuff .javastuff
 +
 +.pystuff:
 +	$(MAKE) -C python
 +	touch $@
 +
++.javastuff:
++	$(MAKE) -C java
++	touch $@
++
 +$(LIBFILE): svm.o
 +	$(CXXC) -shared -Wl,-soname,$(LIBNAME).$(LVER) -o $(LIBFILE) svm.o $(LDFLAGS) && \
 +	ln -s $(LIBFILE) $(LIBNAME).$(LVER) && \
@@ -56,7 +58,7 @@
 +
  clean:
 -	rm -f *~ svm.o svm-train svm-predict svm-scale
-+	rm -f *~ svm.o svm-train svm-predict svm-scale $(LIBNAME)* *-stamp .pystuff && make -C python clean
++	rm -f *~ svm.o svm-train svm-predict svm-scale $(LIBNAME)* *-stamp .pystuff && make -C python clean && make -C java clean
 +
 +install: install-headers install-library
 +
@@ -66,10 +68,8 @@
 +install-library:
 +	install -D $(LIBFILE) $(DESTDIR)/usr/lib/
 +
-Index: libsvm-2.89/python/Makefile
-===================================================================
---- libsvm-2.89.orig/python/Makefile	2009-03-16 12:12:16.000000000 +0800
-+++ libsvm-2.89/python/Makefile	2009-03-16 12:12:30.000000000 +0800
+--- a/python/Makefile
++++ b/python/Makefile
 @@ -1,30 +1,44 @@
 -CXX? = g++
 +CC = g++

Attachment: signature.asc
Description: Digital signature

Reply via email to