notfound 557623 0.48-2a0.mrvn.1
found 557623 0.48-1
retitle 260664 quilt should remember location of patches dir and series file
forcemerge 260664 557623
thanks

On Mon, 23 Nov 2009, Goswin von Brederlow wrote:
> Version: 0.48-2a0.mrvn.1

You should know to only use released version numbers...

> The attached patch makes quilt add .pc/quilt_patches and
> ..pc/quilt_series files when first creating the .pc directory and makes
> it use those files to override any other setting if they exist. It
> also make the two relative if they are inside the current directory
> (dpkg-source sets them absolut) so renaming the source directory
> doesn't invalidate them.

Please fix:
- it should still respect QUILT_PATCHES and QUILT_SERIES the environment
  variables by default, reading the value from .pc should be a fallback IMO
- it should probably use .pc/.quilt_patches and .pc/.quilt_series to
  keep the namespace free for patches (I guess that's the reason why
  it has .pc/.version and not .pc/version too)

I don't think the "relativize_path" stuff is required. But if you keep it,
it should be cleaned. All functions have local variable definition instead
of using $1 directly, please respect that coding style.

Otherwise I like the idea and will suggest it upstream. Please
provide a git patch ready to be commited on top of:
git://git.sv.gnu.org/quilt.git

Cheers,
-- 
Raphaƫl Hertzog



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to