Package: dovecot-common
Version: 1:1.2.8-1
Severity: normal
Tags: patch
User: initscripts-ng-de...@lists.alioth.debian.org
Usertags: incorrect-dependency missing-dependency

Hi Debian Dovecot maintainers.

I believe the run-time dependencies in the LSB fields in the header 
of the init script are partly incorrect or missing. After reading
"Dependency based boot sequence"ยน I'd suggest to add $local_fs and
$remote_fs to the Required-{Start,Stop} headers. 

In addition Dovecot should wait for the availableness of postgresql
and/or mysql.
Many installation uses a SQL backend to store user/password information
for Dovecot. Thus, I suggest to add postgresql and mysql to the Should-
{Start,Stop} headers.

I've attached a patch with the above mentioned modifications.


Regards,
Pascal
--
1 = http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dovecot-common depends on:
ii  adduser                3.111             add and remove users and groups
ii  libbz2-1.0             1.0.5-3           high-quality block-sorting file co
ii  libc6                  2.10.1-7          GNU C Library: Shared libraries
ii  libcomerr2             1.41.9-1          common error description library
ii  libdb4.8               4.8.24-1          Berkeley v4.8 Database Libraries [
ii  libgssapi-krb5-2       1.7dfsg~beta3-1   MIT Kerberos runtime libraries - k
ii  libk5crypto3           1.7dfsg~beta3-1   MIT Kerberos runtime libraries - C
ii  libkrb5-3              1.7dfsg~beta3-1   MIT Kerberos runtime libraries
ii  libldap-2.4-2          2.4.17-2.1        OpenLDAP libraries
ii  libmysqlclient16       5.1.37-2          MySQL database client library
ii  libpam-runtime         1.1.0-4           Runtime support for the PAM librar
ii  libpam0g               1.1.0-4           Pluggable Authentication Modules l
ii  libpq5                 8.4.1-1           PostgreSQL C client library
ii  libsqlite3-0           3.6.20-1          SQLite 3 shared library
ii  libssl0.9.8            0.9.8k-6          SSL shared libraries
ii  openssl                0.9.8k-6          Secure Socket Layer (SSL) binary a
ii  ucf                    3.0024            Update Configuration File: preserv
ii  zlib1g                 1:1.2.3.3.dfsg-15 compression library - runtime

dovecot-common recommends no packages.

Versions of packages dovecot-common suggests:
pn  ntp                           <none>     (no description available)

-- no debconf information
--- dovecot-1.2.8.orig/debian/dovecot-common.init       2009-11-23 
16:39:14.000000000 +0100
+++ dovecot-1.2.8/debian/dovecot-common.init    2009-11-26 07:16:11.000000000 
+0100
@@ -1,10 +1,10 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          dovecot
-# Required-Start:    $syslog
-# Required-Stop:     $syslog
-# Should-Start:      $local_fs $time ntp
-# Should-Stop:       $local_fs
+# Required-Start:    $local_fs $remote_fs $syslog
+# Required-Stop:     $local_fs $remote_fs $syslog
+# Should-Start:      $time postgresql mysql ntp
+# Should-Stop:       postgresql mysql
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Dovecot init script

Reply via email to