Package: gitk
Version: 1:1.6.5.2-1
Severity: wishlist

Hi Gerrit,

I have been using this patch locally.  Maybe it could be useful
for Debian, too.

I did not update PYTHON_PATH because the latest git release does
not use it, and future git versions use it in #! lines.

What do you think?

-- %< --
Subject: debian/rules: TCLTK_PATH=wish

Do not use the full path to wish in the generated gitk script.
The TCLTK_PATH Makefile variable defaults to a bare 'wish', but
ever since commit 09616a4 (debian/rules: add
TCLTK_PATH=/usr/bin/wish8.4 to OPTS (closes: #438662).,
2007-08-25), Debian has been using an absolute path instead.  Any
custom Tcl/Tk version installed in /usr/local/bin or ~/bin does
not get used.

As Debian policy 6.1 notes, it is nicer for scripts not to
override user preferences this way.

Signed-off-by: Jonathan Nieder <jrnie...@gmail.com>
---
 debian/rules |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debian/rules b/debian/rules
index 35d5333..4425255 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,7 +8,7 @@ STRIP =strip
 TEST =test
 OPTS =NO_OPENSSL=1 prefix=/usr gitexecdir=/usr/lib/git-core \
   mandir=/usr/share/man INSTALLDIRS=vendor WITH_P4IMPORT=1 \
-  PYTHON_PATH=/usr/bin/python TCLTK_PATH=/usr/bin/wish \
+  PYTHON_PATH=/usr/bin/python \
   THREADED_DELTA_SEARCH=1
 
 ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
-- 
1.6.5.2




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to