On Sat, 7 Nov 2009, Rene Weber wrote:
I've closed this bug now with an upload that neuters the
dailystrips-update program temporarily with a view to removing it entirely
(this provides a migration period for people to remove it without getting
cron errors or the such immediately).
Personally I think cron errors are a good thing - if you eventually intend
to get rid of it (to encourage people to remove it from their cron). But
if you intend to eventually provide a new location for the defs files,
then a quiet exit is good.
I've also strengthened the warning in the dailystrips-update man page
and the README, although please note that the man page in particular has
been warning against its use since 2007.
I saw - somehow I missed it though, and I did read the man page.
Still, I don't disagree with most of what you say (I won't unilaterally
remove a local defs file in case it has value), so I hope you agree this is
sufficient.
How about if the defs file has cksum: 1308086821, length: 93060 remove it?
(cksum not md5 to avoid a dependency). This way you only remove the known
old/bad file.
I took the liberty of making a patch for you.
-Ariel*** dailystrips-update.old Sat Nov 7 21:05:51 2009
--- dailystrips-update Sat Nov 7 21:05:22 2009
***************
*** 11,20 ****
# Current Revision: 1.0.0
#
- # "dailystrips-update" is deprecated as upstream is dead, it will be removed
- # in a future release.
- exit(0);
-
# Set up
use strict;
no strict qw(refs);
--- 11,16 ----
***************
*** 148,156 ****
# Download new definitions and save
unless ($options{'quiet'})
{
! print "dailystrips-update $version starting...\n";
}
&get_updated_defs($options{'updates'});
--- 144,166 ----
# Download new definitions and save
unless ($options{'quiet'})
{
! # print "dailystrips-update $version starting...\n";
! print "dailystrips-update $version is currently disabled, if you have a known bad version of the defs file, it has been removed.\n";
}
+ # temporarily remove known bad version of defs file, if it exists
+ if(-e $options{'updates'}) {
+ my $cksum = `cksum $options{'updates'} | cut -d ' ' -f 1-2`;
+ chomp $cksum;
+ if($cksum == "1308086821 93060") {
+ unlink $options{'updates'};
+ }
+ }
+
+ # "dailystrips-update" is deprecated as upstream is dead, it will be removed
+ # in a future release.
+ exit(0);
+
&get_updated_defs($options{'updates'});
