On Sun, Oct 25, 2009 at 12:12:17AM -0500, Kumar Appaiah wrote: > Your changes seem good enough for Python 2.6, so I believe you've > solved the bug. Unfortunately, I made you bump the least version of > Python to 2.5.4, which might cause a bit of pain to backporters. In > order to undo that effect, I've attached a patch against your latest > upload, which would allow you to relax the Python version back to > 2.4. Please do review and consider for inclusion in the next upload, > if you want to support backporting. If you don't deem it necessary, > that's also fine.
Argh! I've attached it now. Kumar -- Kumar Appaiah
>From 4a56805c64ae5abb4ad6e1281809a1cc9744d0a3 Mon Sep 17 00:00:00 2001 From: Kumar Appaiah <aku...@debian.org> Date: Sun, 25 Oct 2009 00:03:49 -0500 Subject: [PATCH] Changes to relax minimum python depencency In order to relax the minimum Python version required to build the package (and thereby ease backporting), modify debian/rules to conditionally use the macros from python.mk. This change has been made to ease backporting. Signed-off-by: Kumar Appaiah <aku...@debian.org> --- debian/control | 2 +- debian/rules | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/debian/control b/debian/control index a1ea335..8e660f5 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,7 @@ Section: sound Priority: optional Maintainer: Tristan Seligmann <mithra...@mithrandi.net> Uploaders: Christine Spang <christ...@debian.org> -Build-Depends: debhelper (>= 7.0.50~), python-dev (>= 2.5.4), +Build-Depends: debhelper (>= 7.0.50~), python-dev (>= 2.4), python-gtk2-dev (>= 2.12), pkg-config, libgtk2.0-dev, intltool, python-support (>= 0.90), quilt Standards-Version: 3.8.3 diff --git a/debian/rules b/debian/rules index 4e6c479..c58a4f2 100755 --- a/debian/rules +++ b/debian/rules @@ -2,12 +2,15 @@ %: dh --with quilt $@ -include /usr/share/python/python.mk +-include /usr/share/python/python.mk DEFAULT_PYTHON = `pyversions -d` -# for some reason, py_sitename hates quoted strings, no use py_sitename_sh +# for some reason, py_sitename hates quoted strings, now use py_sitename_sh # instead PYLIBDIR = $(call py_libdir_sh,$(DEFAULT_PYTHON)) +ifeq ($(PYLIBDIR),) +PYLIBDIR = /usr/lib/${DEFAULT_PYTHON}/site-packages +endif IMAGES_DIR = debian/tmp${PYLIBDIR}/quodlibet/images EXFALSO_ICON = ${IMAGES_DIR}/exfalso.png QUODLIBET_ICON = ${IMAGES_DIR}/quodlibet.png -- 1.6.5