Package:  cgroup-bin
Version:  0.34-1
Severity: serious
Tags:     patch
User:     initscripts-ng-de...@lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts of this package.  The scripts uses files
in /usr/ and should depend on $remote_fs, and used to start after
syslog and should probably depend on $syslog to continue to do so.
The cgred script have a bogus dependency on $cgconfig, which should
loose the virtual facility indicator ($).

This patch should solve the issue.  Setting severity to serious, as
cgred might fail to start after cgconfig with the current
dependencies.

diff -ur ../libcgroup-0.34/scripts/init.d/cgconfig.in 
../libcgroup-0.34-pere/scripts/init.d/cgconfig.in
--- ../libcgroup-0.34/scripts/init.d/cgconfig.in        2009-05-08 
07:15:25.000000000 +0200
+++ ../libcgroup-0.34-pere/scripts/init.d/cgconfig.in   2009-10-03 
19:59:32.000000000 +0200
@@ -21,10 +21,8 @@

 ### BEGIN INIT INFO
 # Provides:             cgconfig
-# Required-Start:
-# Required-Stop:
-# Should-Start:
-# Should-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Short-Description:    start and stop the WLM configuration
 # Description:          This script allows us to create a default configuration
 ### END INIT INFO
diff -ur ../libcgroup-0.34/scripts/init.d/cgred.in 
../libcgroup-0.34-pere/scripts/init.d/cgred.in
--- ../libcgroup-0.34/scripts/init.d/cgred.in   2009-05-18 10:14:39.000000000 
+0200
+++ ../libcgroup-0.34-pere/scripts/init.d/cgred.in      2009-10-03 
19:59:55.000000000 +0200
@@ -23,10 +23,8 @@
 #
 ### BEGIN INIT INFO
 # Provides:            cgrulesengd
-# Required-Start:      $local_fs $syslog $cgconfig
-# Required-Stop:       $local_fs $syslog
-# Should-Start:
-# Should-Stop:
+# Required-Start:      $remote_fs $syslog cgconfig
+# Required-Stop:       $remote_fs $syslog
 # Short-Description:   start and stop the cgroups rules engine daemon
 # Description:         CGroup Rules Engine is a tool for automatically using \
 #                      cgroups to classify processes

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to