Package: incron
Version: 0.5.8-1
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch
Hi,
In Ubuntu, the default is hardened/optimised mode, and this provoque a
compiletion error in incron:
g++ -c -O2 -g0 -Wall -pipe -o incroncfg.o incroncfg.cpp
incroncfg.cpp: In static member function 'static bool
IncronCfg::IsComment(const char*)':
incroncfg.cpp:184: error: invalid conversion from 'const char*' to 'char*'
make[1]: *** [incroncfg.o] Error 1
make[1]: Leaving directory `/build/buildd/incron-0.5.8'
dh_auto_build: make returned exit code 2
make: *** [build-stamp] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
This is fixed by the following patch.
Cheers,
Fabrice
*** /tmp/tmp0xfbYU
In Ubuntu, we've applied the attached patch to achieve the following:
* debian/patches/fix_ftbfs_hardened_gcc44: patch incroncfg.cpp to avoid a
cast from const char * to char *. This fix a FTBFS in hardened mode.
We thought you might be interested in doing the same.
-- System Information:
Debian Release: squeeze/sid
APT prefers karmic-updates
APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.28-15-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -u incron-0.5.8/debian/patches/series incron-0.5.8/debian/patches/series
--- incron-0.5.8/debian/patches/series
+++ incron-0.5.8/debian/patches/series
@@ -3,0 +4 @@
+fix_ftbfs_hardened_gcc44
only in patch2:
unchanged:
--- incron-0.5.8.orig/debian/patches/fix_ftbfs_hardened_gcc44
+++ incron-0.5.8/debian/patches/fix_ftbfs_hardened_gcc44
@@ -0,0 +1,13 @@
+Index: incron-0.5.8/incroncfg.cpp
+===================================================================
+--- incron-0.5.8.orig/incroncfg.cpp 2009-09-28 18:52:29.000000000 +0000
++++ incron-0.5.8/incroncfg.cpp 2009-09-28 18:52:57.000000000 +0000
+@@ -181,7 +181,7 @@
+
+ bool IncronCfg::IsComment(const char* s)
+ {
+- char* sx = strchr(s, '#');
++ const char* sx = strchr(s, '#');
+ if (sx == NULL)
+ return false;
+
