Package: lastmp Version: 0.37-2 Severity: serious Tags: patch User: initscripts-ng-de...@lists.alioth.debian.org Usertags: incorrect-dependency User: debian...@lists.debian.org Usertags: piuparts
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d scripts of this package. The lastmp script have a hard dependency on mpd, yet the package do not depend on it. Because of this, the init.d dependency should be a soft dependency. The package description for lastmp make me believe it should start after lastfmsubmitd, so I add propose to that dependency. Further, the scripts uses files in /usr/ and should depend on $remote_fs. Last, the scripts used to start after syslog and should probably depend on $syslog to keep that ordering. I discovered these things from piuparts, which failed to install the package. See <URL:http://piuparts.debian.org/sid/fail/lastmp_1.0.5-1.log>. Here are the relevant parts: insserv: Service mpd has to be enabled to start service lastmp insserv: exiting now! I'm setting severity to serous as this will affect all users trying to install the lastmp without the mpd package already installed. This patch should solve it. diff -ur ../lastfmsubmitd-1.0.5/debian/lastfmsubmitd.init.d ../lastfmsubmitd-1.0.5-pere/debian/lastfmsubmitd.init.d --- ../lastfmsubmitd-1.0.5/debian/lastfmsubmitd.init.d 2009-09-27 09:43:13.000000000 +0200 +++ ../lastfmsubmitd-1.0.5-pere/debian/lastfmsubmitd.init.d 2009-09-27 09:45:11.000000000 +0200 @@ -2,8 +2,8 @@ ### BEGIN INIT INFO # Provides: lastfmsubmitd -# Required-Start: $remote_fs -# Required-Stop: $remote_fs +# Required-Start: $remote_fs $syslog +# Required-Stop: $remote_fs $syslog # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: Start and stop lastfmsubmit daemon diff -ur ../lastfmsubmitd-1.0.5/debian/lastmp.init.d ../lastfmsubmitd-1.0.5-pere/debian/lastmp.init.d --- ../lastfmsubmitd-1.0.5/debian/lastmp.init.d 2009-09-27 09:43:13.000000000 +0200 +++ ../lastfmsubmitd-1.0.5-pere/debian/lastmp.init.d 2009-09-27 09:53:01.000000000 +0200 @@ -2,8 +2,10 @@ ### BEGIN INIT INFO # Provides: lastmp -# Required-Start: mpd -# Required-Stop: mpd +# Required-Start: $remote_fs $syslog lastfmsubmitd +# Required-Stop: $remote_fs $syslog lastfmsubmitd +# Should-Start: mpd +# Should-Stop: mpd # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: Start and stop lastfmsubmit daemon Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
