On Sun, 06 Sep 2009, Bill Allombert wrote:
> Good, good, progress at last. Please find a patch that is a port of the
> old patch.3.0 in the first post of #229357 and implement
> Build-Options: build-arch as specified therein.
First, if Build-Options is not integrated with DEB_BUILD_OPTIONS it should
not have the same name. I suggest Features:, Build-Features: or something
similar.
Then, I don't want it to use commas as separator, it should use spaces as
separator like DEB_BUILD_OPTIONS and list of architectures.
To be of any use in other use cases (mainly enabling hardened build
options), it should support having values associated to each feature
(ex: build-arch hardening=a,b,c). Default values for features where one is
not given would be a bonus.
I want to be able to reuse this when I'll write dpkg-buildflags, so
the parsing should be moved outside of dpkg-builpackage, likely in its own
module (somewhat similar to Dpkg::BuildOptions).
And last point, a branch is never ready to be merged if the documentation
is not updated accordingly.
> +$buildtarget='build-arch' if ( $binarytarget == 'binary-arch' &&
> + defined($buildoptions{'build-arch'}));
> +
== is wrong as noted by Cyril.
And the change in dpkg-buildpackage should really be similar to what
I did in
http://git.debian.org/?p=users/hertzog/dpkg.git;a=commitdiff;h=de4a0d2935201352f3b24382a18b8893d9ae2bdf#patch3
The rest should be outside in a module.
Cheers,
--
Raphaël Hertzog
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
