Package: hpoj Version: 0.91-14 Severity: important Tags: patch User: initscripts-ng-de...@lists.alioth.debian.org Usertags: incorrect-dependency incorrect-runlevels
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d scripts of this package. The list of runlevels to stop in is incomplete. The script should stop in runlevel 1 to make sure the service is started again when switching from runlevel 1 to 2-5. Also, if the script need to run during halt (runlevel 0), I find it very likely that it also need to run during reboot (runlevel 6). Also, the script used to start after the syslog collector was started and the source contain references to 'syslog', so I suspect the $syslog facility should be a dependency. I notice from #115984 that this script should start before CUPS. The CUPS scripts have changed provides from cupsys to cups, and the hpoj script need to adjust. I kept the old cupsys dependency for compatibility reasons with older Debian releases. You might want to drop it completely. This patch implement this change. Without it, the script will fail to handle runlevel 1 properly, and might start to early in the boot. diff -ru hpoj-0.91/scripts/ptal-init.in hpoj-0.91-pere/scripts/ptal-init.in --- hpoj-0.91/scripts/ptal-init.in 2009-08-30 22:07:14.000000000 +0200 +++ hpoj-0.91-pere/scripts/ptal-init.in 2009-08-30 22:12:39.000000000 +0200 @@ -1,12 +1,12 @@ #!/usr/bin/perl ### BEGIN INIT INFO # Provides: hpoj -# Required-Start: $remote_fs -# Required-Stop: $remote_fs -# X-Start-Before: cupsys -# X-Stop-after: cupsys +# Required-Start: $remote_fs $syslog +# Required-Stop: $remote_fs $syslog +# X-Start-Before: cups cupsys +# X-Stop-after: cups cupsys # Default-Start: 2 3 4 5 -# Default-Stop: 0 +# Default-Stop: 0 1 6 # Short-Description: Start daemon at boot time # Description: Enable service provided by daemon. ### END INIT INFO Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
