On Sat, Aug 22, 2009 at 11:01:21PM +0200, Cyril Brulebois wrote:
> Robert Millan <r...@aybabtu.com> (22/08/2009):
> > > As the failing build is examples/echo/echo-server.cpp, I assumed a
> > > quick and dirty workaround might do, see the attached patch. FWIW,
> > > the _POSIX_HOST_NAME_MAX #define is in
> > > /usr/include/bits/posix1_lim.h, included through limits.h.
> 
> > This looks wrong.
> 
> As I said, it is a *quick and dirty /workaround/*.
> 
> > It should be using sysconf() like the comment above suggests.  If
> > you disagree with what the comment says, you should be providing
> > HOST_NAME_MAX via limits.h.
> 
> I didn't implement using sysconf() because of time constraints and
> lack of interest in fixing an *example* to use sysconf() for a random
> package that FTBFSes while there are many others left.
> 
> So: I don't disagree with… what I was previously saying.

No need to grumpy.  As I said before:

> Otherwise, let me know and I'll fix it to use sysconf() instead, it's a
> pretty easy fix.

I'll make a good fix, send it to upstream and include it in next upload.

Thanks

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to