Le mercredi 19 août 2009 à 12:51 -0400, Zygo Blaxell a écrit :
> To simulate a bad connection, open two IRC clients, point them both at
> the same bip proxy, connect to a big IRC network, kill -STOP one of them,

Great idea, I love it.

> I applied your patch and tested it.  There's one bug left:  when we
> are looping with the write(), we want the loop to repeat if the write
> is successful but incomplete, or if the error is EINTR;

Right.

> Once the following patch is applied on top of yours, though, it works
> like a champ!

There is another bug, related to write_line_fast that bypasses the
output buffer system, that can lead to broken, stream (two partial lines
go to the wire, and then the end of the two lines).
Patched already in git.

> I am a bit worried that it will run my proxy server out of RAM if there
> is an extended network problem; however, my server has more RAM available
> than all of space consumed by my IRC logs combined, so I'll probably
> notice the process growing well before it becomes an issue.

Actually this should be caught by the irc PINGs sent that will timeout
the connection.

I'm merging your fixes.

Thanks a lot!
-- 
Arnaud Cornet




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to