Package: flamethrower Version: 0.1.6-1 Severity: important Tags: patch User: [email protected] Usertags: incorrect-runlevels incorrect-dependency
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d script. The provides should be unique and preferably the name of the script. The current one conflict do not with the any script, but I wanted to mention it. The script need /usr/, and should depend on $remote_fs. The script used to start after syslog, so I suggest making it depend on $syslog. Also the runlevel list do not match the arguments to update-rc.d, it should start in runlevel 2 and 4. <URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html > documents the LSB header format. Some debian notes are available from <URL: http://wiki.debian.org/LSBInitScripts >. This patch should solve the issue. Without it, the script will fail to start in runlevels 2 and 4, and might start to early. In addition to this header change, some code in postinst is needed to remove the stop symlink in rc2.d and add a start symlink in rc2.d and rc4.d during upgrades. diff -ur flamethrower-0.1.8/etc/init.d/flamethrower-server flamethrower-0.1.8-pere/etc/init.d/flamethrower-server --- flamethrower-0.1.8/etc/init.d/flamethrower-server 2009-08-18 21:34:53.000000000 +0200 +++ flamethrower-0.1.8-pere/etc/init.d/flamethrower-server 2009-08-18 21:37:22.000000000 +0200 @@ -16,10 +16,10 @@ # Support for LSB compliant init system: ### BEGIN INIT INFO # Provides: flamethrowerd -# Required-Start: $network $syslog -# Required-Stop: -# Default-Start: 3 5 -# Default-Stop: 0 1 2 6 +# Required-Start: $remote_fs $syslog $network +# Required-Stop: $remote_fs $syslog +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 # Short-Description: Daemon for multicast file distribution # Description: Daemon for multicast file distribution ### END INIT INFO Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
