Package:  pwrkap
Version:  7.30-1
Severity: important
Tags:     patch
User:     initscripts-ng-de...@lists.alioth.debian.org
Usertags: incorrect-dependency

Hi,

While examining some init scripts I found pwrkap's to be missing some 
dependencies.

Since the binary lives in /usr it requires $remote_fs. 
I also added a should- dependency on $network since it looks like it uses 
sockets. If pwrkap may work without any network interface (lo even) then it 
is correct to leave $network as a should- dependency, otherwise please move 
it to required-.

http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
documents the LSB header format.  Some Debian notes are available at
http://wiki.debian.org/LSBInitScripts

This patch should solve the issue.  Without it, the init.d will start too 
early in the boot sequence on some systems.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
diff -urpN pwrkap-7.30-1.orig/debian/pwrkap.init pwrkap-7.30-1/debian/pwrkap.init
--- pwrkap-7.30-1.orig/debian/pwrkap.init	2009-08-14 18:52:27.000000000 -0500
+++ pwrkap-7.30-1/debian/pwrkap.init	2009-08-14 18:59:06.014947232 -0500
@@ -5,10 +5,12 @@
 
 ### BEGIN INIT INFO
 # Provides:          pwrkap
-# Required-Start:
-# Required-Stop:
-# Default-Start:     3 5
-# Default-Stop:
+# Required-Start:    $remote_fs
+# Required-Stop:     $remote_fs
+# Should-Start:      $network
+# Should-Stop:       $network
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: pwrkap initscript
 # Description:       This script take care of starting and stopping the
 #                    pwrkap daemon.

Reply via email to