Package: classpath
Version: 2:0.98-2
Severity: important
Tags: patch
User: debian-...@lists.debian.org
Usertags: kfreebsd

Hi,

thanks for the DEB_HOST_ARCH_OS check, but that's not sufficient. When
dh_installing, some files are missing (usr/lib/classpath/libgj* from
classpath.install).

Given that those files appear to be:
| /usr/lib/classpath/libgjsmalsa.la
| /usr/lib/classpath/libgjsmalsa.so
| /usr/lib/classpath/libgjsmdssi.la
| /usr/lib/classpath/libgjsmdssi.so
according to the contents of the amd64 classpath binary, I'm proposing
the attached patch, making the installation of those files conditional,
and making their name explicit (in case some other non-Linux libgj*
files get added in the future).

[ By the way, you're creating a stamp file which is used nowhere in
  debian/rules AFAICT, and not cleaned after the build:
  | dpkg-source: warning: newly created empty file 'configured-stamp' will not 
be represented in diff
]

Thanks for considering.

Mraw,
KiBi.
diff -u classpath-0.98/debian/rules classpath-0.98/debian/rules
--- classpath-0.98/debian/rules
+++ classpath-0.98/debian/rules
@@ -145,6 +145,13 @@
 	dh_testdir
 	dh_testroot
 	dh_install -a --sourcedir=debian/tmp
+ifeq ($(DEB_HOST_ARCH_OS),linux)
+	# Install alsa & dssi bits, only on Linux (previously:
+	# usr/lib/classpath/libgj* in classpath.install, but let's
+	# make it explicit).
+	dh_install -pclasspath --source=debian/tmp usr/lib/classpath/libgjsmalsa.*
+	dh_install -pclasspath --source=debian/tmp usr/lib/classpath/libgjsmdssi.*
+endif
 	dh_installdocs -a
 	dh_installexamples -a
 	dh_installman -a
diff -u classpath-0.98/debian/classpath.install classpath-0.98/debian/classpath.install
--- classpath-0.98/debian/classpath.install
+++ classpath-0.98/debian/classpath.install
@@ -1,3 +1,4 @@
 usr/lib/classpath/libgconfpeer*
-usr/lib/classpath/libgj*
+# Now installed conditionally from debian/rules:
+# usr/lib/classpath/libgj*
 usr/lib/classpath/libj*

Reply via email to