On Fri, 7 Aug 2009, Matthew Wilcox wrote: > On Fri, Aug 07, 2009 at 01:48:34PM -0400, Tim Abbott wrote: > > tag 476328 +patch > > thanks > > > > I've attached a patch to split the package into a kerneloops package and a > > kerneloops-applet package. The new kerneloops package has just the > > daemon, and works as though "allow-submit = ask" were set to "no". There > > may be some migration cost of people who upgrade and lose the GUI, but I > > think that this is a substantially better design than having two packages > > that both contain indentical copies of the kerneloops daemon, init script, > > etc. > > > > Later, we can try to implement an "allow-submit = ask" system for when one > > doesn't have a GUI using one of the schemes from this bug report. > > How about we do this the opposite way round, where we have > a kerneloops-daemon package, and the kerneloops package depends > on it? That way, people who upgrade from current kerneloops lose no > functionality, and new installs who want to get rid of the applet can > just install kerneloops-daemon?
Hmm. I think long-term it would be best to have the names be kerneloops/kerneloops-applet. kerneloops-daemon/kerneloops is certainly much better than kerneloops-nogui/kerneloops, but I think is still a bit confusing. It may very well be justified by saving the current userbase from having things change out from under them. Of course, the number of users with kerneloops installed in the future will be much greater than those at present, since it seems Ubuntu is planning to put kerneloops in the default installation for Karmic: <https://bugs.launchpad.net/ubuntu/+source/kerneloops/+bug/327819> -Tim Abbott > > > (I also submitted this patch to this Ubuntu bug: > > <https://bugs.launchpad.net/ubuntu/+source/kerneloops/+bug/337757>) > > > > -Tim Abbott > > From 439668b7c0b40ac60455b2cf1989ca29051de8e5 Mon Sep 17 00:00:00 2001 > > From: Tim Abbott <tabb...@ksplice.com> > > Date: Thu, 23 Jul 2009 11:10:05 -0400 > > Subject: [PATCH] Split the kerneloops package into kerneloops and > > kerneloops-applet. > > > > Signed-off-by: Tim Abbott <tabb...@ksplice.com> > > --- > > debian/control | 8 ++++++++ > > debian/kerneloops-applet.install | 3 +++ > > debian/kerneloops.install | 2 ++ > > debian/rules | 6 ++++-- > > 4 files changed, 17 insertions(+), 2 deletions(-) > > create mode 100644 debian/kerneloops-applet.install > > create mode 100644 debian/kerneloops.install > > mode change 100644 => 100755 debian/rules > > > > diff --git a/debian/control b/debian/control > > index 0e93c6a..3de12ca 100644 > > --- a/debian/control > > +++ b/debian/control > > @@ -14,3 +14,11 @@ Description: kernel oops tracker > > kerneloops is a daemon that collects kernel crash information and then > > submits the extracted signature to the kerneloops.org website for > > statistical analysis and presentation to the Linux kernel developers. > > + > > +Package: kerneloops-applet > > +Architecture: any > > +Depends: ${shlibs:Depends}, kerneloops > > +Description: applet for the kernel oops tracker > > + The kerneloops applet allows the kerneloops crash reporting utility > > + to ask a desktop user for permission before submitting an oops report > > + to the kerneloops.org website. > > diff --git a/debian/kerneloops-applet.install > > b/debian/kerneloops-applet.install > > new file mode 100644 > > index 0000000..3850712 > > --- /dev/null > > +++ b/debian/kerneloops-applet.install > > @@ -0,0 +1,3 @@ > > +debian/tmp/usr/bin/kerneloops-applet /usr/bin > > +debian/tmp/usr/share/kerneloops /usr/share > > +debian/tmp/usr/share/locale /usr/share > > diff --git a/debian/kerneloops.install b/debian/kerneloops.install > > new file mode 100644 > > index 0000000..cb7f717 > > --- /dev/null > > +++ b/debian/kerneloops.install > > @@ -0,0 +1,2 @@ > > +debian/tmp/usr/sbin/kerneloops /usr/sbin/ > > +debian/tmp/usr/share/man/man8/* /usr/share/man/man8/ > > diff --git a/debian/rules b/debian/rules > > old mode 100644 > > new mode 100755 > > index dfe7ee3..ebf8678 > > --- a/debian/rules > > +++ b/debian/rules > > @@ -27,8 +27,10 @@ install: build > > dh_installdirs > > > > # Add here commands to install the package into debian/<packagename> > > - $(MAKE) DESTDIR=`pwd`/debian/`dh_listpackages` install > > + $(MAKE) DESTDIR=`pwd`/debian/tmp install > > install -D -m 0755 kerneloops.init > > `pwd`/debian/kerneloops/etc/init.d/kerneloops > > + dh_install -pkerneloops > > + dh_install -pkerneloops-applet > > > > # Build architecture-independent files here. > > binary-indep: build install > > @@ -41,7 +43,7 @@ binary-arch: build install > > dh_installchangelogs > > dh_installdocs > > dh_installexamples > > - dh_installinit -o > > + dh_installinit -pkerneloops -o > > # dh_installdebconf > > # dh_installman kerneloops.8 > > dh_link > > -- > > 1.6.3.3 > > > > > -- > Matthew Wilcox Intel Open Source Technology > Centre > "Bill, look, we understand that you're interested in selling us this > operating system, but compare it to ours. We can't possibly take such > a retrograde step." > -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
