Uwe Kleine-König wrote: > Hello Franck, Hi,
> note I didn't test your patch, only read through. I didn't even read > the prose part. I assume you only changed the formating!? I must admit I have updated some sentences to fit into the manapges and then a full review is necessary before publishing it. In addition, I have put all the manpages at the end of the README file, and added a small description to the list of commands where they were enumerated with their long description in a first place. >> diff --git a/debian/control b/debian/control >> index 35f6761..596e71a 100644 >> --- a/debian/control >> +++ b/debian/control >> @@ -4,6 +4,7 @@ Priority: optional >> Maintainer: Debian TopGit maintainers <pkg-top...@teams.debian.net> >> Uploaders: martin f. krafft <madd...@debian.org>, Uwe Kleine-König >> <u.kleine-koe...@pengutronix.de> >> Build-Depends: debhelper (>= 6), quilt >> +Build-Depends-Indep: asciidoc, xmlto > hhhm. I didn't start with using Build-Depends:, but as topgit is an > arch=all package, I wonder if most if not all dependencies should be > Build-Depends-Indep:. Martin? As a matter of fact, according to policy 7.7 http://www.debian.org/doc/debian-policy/ch-relationships.html#s-sourcebinarydeps [quote] Build-Depends, Build-Conflicts The Build-Depends and Build-Conflicts fields must be satisfied when any of the following targets is invoked: build, clean, binary, binary-arch, build-arch, build-indep and binary-indep. [/quote] and debhelper is used at least in the clean target. So, that should be fine. (Same argument for quilt) >> --- a/debian/rules >> +++ b/debian/rules >> @@ -5,19 +5,28 @@ >> >> TG_BRANCHES="fixes/ensure-worktree debian/locations" >> >> +TG_MANS := $(patsubst %.sh,%.1,$(wildcard tg-*.sh)) >> + > Does the package still build after > > $ touch tg-astillundocumentedcommand.sh > > ? You are right, it fails. >> diff --git a/debian/topgit.manpages b/debian/topgit.manpages >> new file mode 100644 >> index 0000000..98712e7 >> --- /dev/null >> +++ b/debian/topgit.manpages >> @@ -0,0 +1,10 @@ >> +tg-create.1 >> +tg-delete.1 >> +tg-depend.1 >> +tg-import.1 >> +tg-info.1 >> +tg-mail.1 >> +tg-patch.1 >> +tg-remote.1 >> +tg-summary.1 >> +tg-update.1 > What about autogenerating this file? It sounds a bit strange to me to generate debhelper files automatically, but why not :) I am not worrying about patching the debian directory, since I think the manpages could be added upstream and generated from the main Makefile. I mean, the manpages are not Debian specific. Anyway, I will fix the mistake you found in debian/rules, and continue to create the tg manpage. > Best regards and thanks for your efforts You're welcome, Regards, -- Franck Joncourt http://debian.org - http://smhteam.info/wiki/
signature.asc
Description: OpenPGP digital signature
