* Max Bowsher <m...@f2s.com> [090801 17:32]:
> The --keepunreferencedfiles option is most useful in the conf/options
> file to set policy for a repository to not remove files at time of
> obsoletion.
>
> However, if you put it in conf/options, you then cannot use "reprepro
> deleteunreferenced" at all, as reprepro complains:
>
>   Calling deleteunreferenced with --keepunreferencedfiles does not
>   really make sense, does it?
>
> Whilst I agree calling "reprepro --keepunreferencedfiles
> deleteunreferenced" is nonsense, calling "reprepro deleteunreferenced"
> with keepunreferencedfiles in conf/options is quite reasonable.
>
> I would like to suggest simply removing the  "does not make sense" check
> to allow this to work, and not bothering with any special handling of
> the edge case of "reprepro --keepunreferencedfiles deleteunreferenced"
> on the command line, since it's such a nonsensical command to give.

I consider deleteunreferenced a normal maintaince command that should
not break things. If someone does not want things deleted at all,
having that command delete things is therefor a bit problematic in my
eyes. (And I do not want to check if allowing this to be run with
keepunreferenced causes any funny effects in the general code).

I've changed the error message to suggest running with
'--nokeepunreferencedfiles' in case one really want to delete things.

Is that an acceptable compromise for you?

Hochachtungsvoll,
        Bernhard R. Link



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to