tags 539002 + patch thanks One small mistake: MD5 was used in the postinst script via gnudip-lib.pl. So the "use Digest::MD5" should be required there as well.
I've attached an updated patch. Regards, Ansgar
>From d36baf72f55a749a4f29b74a0631bfa5a3c78037 Mon Sep 17 00:00:00 2001 From: Ansgar Burchardt <[email protected]> Date: Tue, 28 Jul 2009 15:04:03 +0200 Subject: [PATCH] Use Digest::MD5 instead of MD5 The MD5 Perl module has been deprecated by Digest::MD5 several years ago. --- debian/control | 2 +- debian/postinst | 2 +- gdipc.pl | 8 ++++---- gdips.pl | 6 +++--- gnudip-lib.pl | 2 +- gnudip2.cgi | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/debian/control b/debian/control index d73e8de..27b30e7 100644 --- a/debian/control +++ b/debian/control @@ -7,7 +7,7 @@ Standards-Version: 3.7.2 Package: gnudip Architecture: all -Depends: perl5, mysql-gpl-client | mysql-client, cron, libdbi-perl, libdbd-mysql-perl, libmd5-perl +Depends: perl5, mysql-gpl-client | mysql-client, cron, libdbi-perl, libdbd-mysql-perl Recommends: httpd Description: scripts for dynamic IP to name mappings GnuDIP is a service designed for an ISP to give its customers a static DNS diff --git a/debian/postinst b/debian/postinst index e17eacb..885f40f 100644 --- a/debian/postinst +++ b/debian/postinst @@ -10,7 +10,7 @@ use strict; use DBI; -use MD5; +use Digest::MD5; require '/usr/share/gnudip/gnudip-lib.pl'; diff --git a/gdipc.pl b/gdipc.pl index 993463a..c2d81a4 100755 --- a/gdipc.pl +++ b/gdipc.pl @@ -15,7 +15,7 @@ use Socket; use strict; - use MD5; + use Digest::MD5; #### Set up varialbes my $VER = "2.1.1"; @@ -79,7 +79,7 @@ my $newserverip = <STDIN>; chop($newserverip); - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($newpass); my $digest = $md5->digest(); my $digestpass = unpack("H*", $digest); @@ -116,7 +116,7 @@ my $serverip = <STDIN>; chop($serverip); - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($pass); my $digest = $md5->digest(); my $digestpass = unpack("H*", $digest); @@ -180,7 +180,7 @@ sub sendlogin { chomp(my $sharedsecret = <SERVER>); - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($pass.'.'.$sharedsecret); my $digest = $md5->digest(); my $digeststr = unpack("H*", $digest); diff --git a/gdips.pl b/gdips.pl index e97ece8..40228ff 100755 --- a/gdips.pl +++ b/gdips.pl @@ -13,7 +13,7 @@ use DBI; -use MD5; +use Digest::MD5; use Socket; use Symbol; use POSIX; @@ -203,7 +203,7 @@ sub make_new_child { } $sth->execute; my @checkinfo = $sth->fetchrow_array; - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($checkinfo[2].'.'.$sharedsecret); my $digest = $md5->digest(); my $checkpass = unpack("H*", $digest); @@ -243,7 +243,7 @@ sub make_new_child { } $sth->execute; my @checkinfo = $sth->fetchrow_array; - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($checkinfo[2].'.'.$sharedsecret); my $digest = $md5->digest(); my $checkpass = unpack("H*", $digest); diff --git a/gnudip-lib.pl b/gnudip-lib.pl index 6e2a5d2..022de2a 100644 --- a/gnudip-lib.pl +++ b/gnudip-lib.pl @@ -67,7 +67,7 @@ sub gensum { my $string = shift; - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($string); my $digest = $md5->digest(); my $sum = unpack("H*", $digest); diff --git a/gnudip2.cgi b/gnudip2.cgi index 2d995bf..384c4e4 100755 --- a/gnudip2.cgi +++ b/gnudip2.cgi @@ -13,7 +13,7 @@ #### Load needed modules use DBI; use CGI; - use MD5; + use Digest::MD5; use strict; my ($sth, $mons, $nummon, $printheader, $remote_ip); require '/usr/share/gnudip/gnudip-lib.pl'; @@ -1519,7 +1519,7 @@ sub md5sum { my $string = shift; - my $md5 = new MD5; + my $md5 = new Digest::MD5; $md5->add($string); my $digest = $md5->digest(); my $md5sum = unpack("H*", $digest); -- 1.6.3.3
