-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
This patch does the minimum required to make af compile, but there are
a number of serious problems with the source:
* It's written in K&R C. This has been obsolete for 16 years, and
must be converted. GCC will not support K&R forever; -traditional
has already been removed.
* It wrongly prototypes all the functions and exported variables from
the standard library, including errno. This is *totally broken*,
and will result in a non-functional program on a modern glibc, and
will also fail on amd64.
So, for each C file in the source, you need to:
* Remove *all* function prototypes from external libraries.
* Make sure all the required standard headers are included.
* Remove all variables (e.g. getopt optopt etc.) that are marked
* extern in the standard headers.
* Use ISO C function definitions and declarations instead of the old
K&R ones.
* If functions are used in compilation units other than the one they
were defined in, make sure they are prototyped in a header.
If upstream is dead, or you are not able to do this, I suggest you
request its removal, because it's well obsolete as it stands. If
upstream think this is acceptable in 2005, they need whacking with a
cluebat.
Regards,
Roger
- --
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>
iD8DBQFC0EDRVcFcaSW/uEgRAlBWAKDMRK8VJKCWSfZLd7MuyHwL/4eBkgCgxTT5
nIURPvSMd/Z+GQ31AhheHYg=
=deWA
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
