severity 535452 normal
tags 535452 +pending
thanks

OK, I see what's going on.  We're freeing the mountpoint information
so when we print it in an error message, the error message is getting
printed as garbage.

This probably doesn't qualify as a severity "important" level bug ("a
bug which has a major effect on the usability of a package, without
rendering it completely unusable to everyone"), so I've downgraded it
to normal.

I've checked a fix into the e2fsprogs git tree, and it will be fixed
in the next release.

Thanks for reporting the bug!

                                                - Ted

commit 3a4d9869d47c462c84688b0f8b15df5ab6f93381
Author: Theodore Ts'o <ty...@mit.edu>
Date:   Thu Jul 2 13:54:22 2009 -0400

    resize2fs: Fix error message so the mountpoint is printed correctly
    
    The resize2fs program was freeing the mountpoint information too
    early, so garbage was getting printed instead of the correct
    information in an error message.
    
    Addresses-Debian-Bug: #535452
    
    Signed-off-by: "Theodore Ts'o" <ty...@mit.edu>

diff --git a/resize/main.c b/resize/main.c
index 9b03ba9..2dae161 100644
--- a/resize/main.c
+++ b/resize/main.c
@@ -250,10 +250,8 @@ int main (int argc, char ** argv)
                                device_name);
                        exit(1);
                }
-               if (!(mount_flags & EXT2_MF_MOUNTED) || (mtpt[len-1] == 0)) {
-                       free(mtpt);
+               if (!(mount_flags & EXT2_MF_MOUNTED) || (mtpt[len-1] == 0))
                        break;
-               }
                free(mtpt);
                len = 2 * len;
        }
@@ -453,6 +451,7 @@ int main (int argc, char ** argv)
                                   ((flags & RESIZE_PERCENT_COMPLETE) ?
                                    resize_progress_func : 0));
        }
+       free(mtpt);
        if (retval) {
                com_err(program_name, retval, _("while trying to resize %s"),
                        device_name);



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to