Package: gpaint
Version: 0.3.3-2netbook1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch
*** /tmp/tmp0zG435
In Ubuntu, we've applied the attached patch to achieve the following:
- debian/patches/22_fix_not_printable_string.dpatch: Don't try to
show unprintable characters.
- debian/control: Add missing Build-Depends on libglade-dev
We thought you might be interested in doing the same.
You can test the 'unprintable bug' by trying to add text, then pressing ctrl+d
(or ctrl+ many keys, really). The patch isn't UTF-8 aware, but neither is the
surrounding key press code, so I didn't bother redesigning it.
The libglade fix is because libgnomeprintui no longer pulls it in for us.
Upstream bug: https://savannah.gnu.org/bugs/?26923
Downstream bug: https://bugs.launchpad.net/netbook-remix/+bug/262648
-- System Information:
Debian Release: squeeze/sid
APT prefers karmic-updates
APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: i386 (i686)
Kernel: Linux 2.6.30-10-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u gpaint-0.3.3/debian/control gpaint-0.3.3/debian/control
--- gpaint-0.3.3/debian/control
+++ gpaint-0.3.3/debian/control
@@ -4,7 +4,7 @@
Vcs-Git: git://git.debian.org/git/users/goedson/pkg-gpaint.git
Vcs-Browser: http://git.debian.org/?p=users/goedson/pkg-gpaint.git;a=summary
Maintainer: Goedson Teixeira Paixao <goed...@debian.org>
-Build-Depends: debhelper (>= 4.1.46), libgnomeui-dev, zlib1g-dev, libxml2-dev, libgnomeprint2.2-dev, libgnomeprintui2.2-dev, autotools-dev, dpatch, cdbs
+Build-Depends: debhelper (>= 4.1.46), libgnomeui-dev, zlib1g-dev, libxml2-dev, libgnomeprint2.2-dev, libgnomeprintui2.2-dev, autotools-dev, dpatch, cdbs, libglade2-dev (>= 2.5.1)
Standards-Version: 3.7.2
Package: gpaint
diff -u gpaint-0.3.3/debian/patches/00list gpaint-0.3.3/debian/patches/00list
--- gpaint-0.3.3/debian/patches/00list
+++ gpaint-0.3.3/debian/patches/00list
@@ -7,0 +8 @@
+22_fix_not_printable_string
only in patch2:
unchanged:
--- gpaint-0.3.3.orig/debian/patches/22_fix_not_printable_string.dpatch
+++ gpaint-0.3.3/debian/patches/22_fix_not_printable_string.dpatch
@@ -0,0 +1,22 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 20_fix_not_printable_string_text.c.patch.dpatch by <Ying-Chun Liu (PaulLiu) <grandp...@gmail.com>>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: No description.
+
+...@dpatch@
+diff -urNad gpaint-0.3.3~/src/text.c gpaint-0.3.3/src/text.c
+--- gpaint-0.3.3~/src/text.c 2009-06-30 15:11:40.000000000 -0400
++++ gpaint-0.3.3/src/text.c 2009-06-30 15:12:58.000000000 -0400
+@@ -235,7 +235,10 @@
+ }
+ else if (keyevent->string)
+ {
+- g_string_append(text->textbuf, keyevent->string);
++ if (isprint(keyevent->string[0])) /* not UTF-8 aware */
++ {
++ g_string_append(text->textbuf, keyevent->string);
++ }
+ }
+ else if ((keyevent->keyval >= GDK_space) && (keyevent->keyval < GDK_Shift_L))
+ {
