-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 package netatalk tags 533141 pending thanks
On Tue, Jun 16, 2009 at 03:52:02PM +0200, Frank Lahm wrote: >2009/6/16 Jonas Smedegaard <d...@jones.dk> >> >> You've asked those patches before, and I told you not (as >> >> upstream) to worry about those pathces to autogenerated files): I >> >> agree that they are not of concern for upstream. >> > >> >But you are *not* patching _generated_ files here. You are patching >> >configure.in in this case. ?? >> >> Bingo! >> Until recently I regenerating files, and then switched back to >> applying patches only. I clearly missed that configure.in still got >> patched. Thanks a lot for spotting this. The error is mine. I will >> fix this for the next release (where I will also bump to the official >> upstream release)! > >Great! As said, there are a few more patches doing that, e.g. the >zeroconf patch. I see it now. I was blinded earlier by my (stale!) knowledge about additional patches since dropped. Fix applied to our Git repository now. >> From my current knowledge, I do not even think that >> AM_MAINTAINER_MODE would have helped here: I broke the chain, I need >> to fix it. > >Probably the error code would have been different like "autoconf not >installed" or whatever error is thrown exactly when automake reruns >the autotools chain and one of the tools is not installed on the host. Automake would *not* have run if you (upstream) had included the AM_MAINTAINER_MODE mechanism: Debian packaging is not upstream maintainer, and our build routines includes "--disable-maintainer-mode" to try avoid accidentally invoking autotools. - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEAREDAAYFAko31sgACgkQn7DbMsAkQLiMtACcDtArWrTByIOYoSj935dvKmeM 0U0AnRZhc1L/a+Kmm/d9rUuua0XshcH7 =5SSA -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
