Package: backup-manager Version: 0.7.8-1 Severity: normal Tags: patch Hello! I'm using backup manager with BM_TARBALL_FILETYPE="tar.gz". File changes during the backup are recognized as errors despite the fact that tar return code is "1". This is caused by the bug in backup-methods.sh: BM__CURRENT_COMMAND variable isn't set properly. I've made a small patch. I'm not sure how to fix that correctly but I've tried :) May be it's a good idea to set BM__CURRENT_COMMAND variable in function __get_backup_tarball_command() but it still will not work for encrypted archives. Actually the way backup-manager executes commands doesn't allow to treat this situation properly: error codes are lost in pipelines. May be it's better to pass date through FIFO's and get the error codes separately?
-- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (10, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.29-2-amd64 (SMP w/1 CPU core) Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R) (ignored: LC_ALL set to ru_RU.KOI8-R) Shell: /bin/sh linked to /bin/bash Versions of packages backup-manager depends on: ii debconf [debconf-2.0] 1.5.26 Debian configuration management sy ii findutils 4.4.2-1 utilities for finding files--find, ii gzip 1.3.12-8 GNU compression utilities ii ucf 3.0018 Update Configuration File: preserv backup-manager recommends no packages. Versions of packages backup-manager suggests: pn anacron <none> (no description available) pn dar <none> (no description available) ii dvd+rw-tools 7.1-4 DVD+-RW/R tools ii genisoimage 9:1.1.9-1 Creates ISO-9660 CD-ROM filesystem ii gettext-base 0.17-6 GNU Internationalization utilities pn libfile-slurp-perl <none> (no description available) pn libnet-amazon-s3-perl <none> (no description available) ii openssh-client 1:5.1p1-6 secure shell client, an rlogin/rsh ii perl 5.10.0-22 Larry Wall's Practical Extraction ii perl-modules [libnet-perl] 5.10.0-22 Core Perl modules ii wodim 9:1.1.9-1 command line CD/DVD writing tool ii zip 3.0-1 Archiver for .zip files -- debconf information: backup-manager/upload-key: backup-manager/name-format: long backup-manager/upload-hosts: backup-manager/upload-user-ftp: backup-manager/cron_frequency: daily backup-manager/cron_d_remove_deprecated: false backup-manager/blacklist: /var/archives backup-manager/time-to-live: 5 backup-manager/burning-maxsize: 650 backup-manager/encryption_recipient: backup-manager/transfert_mode: scp backup-manager/dump_symlinks: false backup-manager/upload-user-scp: bmngr backup-manager/burning-device: /dev/cdrom backup-manager/upload-dir: /var/archives/uploads backup-manager/enable_encryption: false * backup-manager/directories: /etc /home * backup-manager/repo_group: root backup-manager/filetype: tar.gz * backup-manager/repo_user: root * backup-manager/backup-repository: /media/md0/archive backup-manager/burning-method: CDRW backup-manager/burning-enabled: false backup-manager/want_to_upload: false -- debsums errors found: debsums: checksum mismatch backup-manager file /usr/share/backup-manager/backup-methods.sh
*** backup-methods.sh.old 2009-06-13 17:27:49.000000000 +0700 --- backup-methods.sh 2009-06-13 17:56:04.000000000 +0700 *************** *** 629,635 **** # the common commandline *) ! BM__CURRENT_COMMAND="generic" debug "$command $file_to_create \"$target\" > $logfile 2>&1" tail_logfile "$logfile" debug "$command $file_to_create \"$target\"" --- 629,640 ---- # the common commandline *) ! # tar, tar.gz, tar.bz2, tar.whatever ! if [[ "${BM_TARBALL_FILETYPE:0:3}" == "tar" ]] ; then ! BM__CURRENT_COMMAND="tar" ! else ! BM__CURRENT_COMMAND="generic" ! fi debug "$command $file_to_create \"$target\" > $logfile 2>&1" tail_logfile "$logfile" debug "$command $file_to_create \"$target\""