Package: acx100
Version: 20080210-1
Severity: normal
Tags: patch

Hi,

Recently I was unable to build the acx module using acx100-source:

    Extracting the package tarball, /usr/src/acx100.tar.gz, please wait...
    "/usr/share/modass/overrides/acx100-source" build KVERS=2.6.29-2-686 
KSRC=/lib/modules/2.6.29-2-686/build KDREV=2.6.29-5 kdist_image
    debian/rules:9: /usr/share/dpatch/dpatch.make: No such file or directory
    make: *** No rule to make target `/usr/share/dpatch/dpatch.make'.  Stop.
    debian/rules:9: /usr/share/dpatch/dpatch.make: No such file or directory
    make: *** No rule to make target `/usr/share/dpatch/dpatch.make'.  Stop.
    BUILD FAILED!
    See 
/usr/src/modass/var_cache_modass/acx100-source.buildlog.2.6.29-2-686.1244731865 
for details.
    Build failed. Press Return to continue...

The build log is attached for your information.

Installing dpatch allowed the build to complete, making me erroneously believe
you had neglected to declare dpatch as a Depends in acx100-source (see
#462118).

But acx100-source doesn't require dpatch for its use, as
01_addRequestInfo.dpatch (and previously, 01_acx100_kcompat-2.6.24.dpatch) is
applied when building this binary package; dpatch being declared in the acx100
source package as a Build-Depends.

As shown in the build log, my reported issue is caused by line 9 of
acx100-source's debian/rules (specifically, modules/acx100/debian/rules within
/usr/src/acx100.tar.gz), which is inherited from acx100:

    include /usr/share/dpatch/dpatch.make

This is also the case in acx100-source 20070101-3, but this package version
had a dpatch Depends defined (bug #462118).

Please find attached a patch revising acx100's debian/rules to comment the
dpatch include line from acx100-source's debian/rules at build time.  A minor
spelling error is also corrected.

Geoff


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.29-2-686 (SMP w/1 CPU core)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
debian/rules:9: /usr/share/dpatch/dpatch.make: No such file or directory
make: *** No rule to make target `/usr/share/dpatch/dpatch.make'.  Stop.
diff -u acx100-20080210/debian/rules acx100-20080210/debian/rules
--- acx100-20080210/debian/rules
+++ acx100-20080210/debian/rules
@@ -7,7 +7,7 @@
 PACKAGE=acx100
 
 include /usr/share/dpatch/dpatch.make
-# modifieable for experiments or debugging m-a
+# modifiable for experiments or debugging m-a
 MA_DIR ?= /usr/share/modass
 # load generic variable handling
 -include $(MA_DIR)/include/generic.make
@@ -43,6 +43,7 @@
 	cp -f debian/copyright debian/build/usr/src/modules/acx100/debian
 	cp -f debian/docs debian/build/usr/src/modules/acx100/debian
 	cp -f debian/rules debian/build/usr/src/modules/acx100/debian
+	sed -i -e 's:include /usr/share/dpatch/dpatch.make:#include /usr/share/dpatch/dpatch.make:' debian/build/usr/src/modules/acx100/debian/rules
 
 	cd debian/build/usr/src/modules/acx100 \
 		&& touch config.mk \

Reply via email to