El miércoles 10 de junio, Guido Günther escribió: > On Fri, Jun 05, 2009 at 11:03:32AM +1000, Felipe Sateler wrote: > > El viernes 5 de junio, Guido Günther escribió: > > > On Thu, Jun 04, 2009 at 07:43:53PM +1000, Felipe Sateler wrote: > > > > Package: git-buildpackage > > > > Version: 0.4.53 > > > > Severity: minor > > > > Tags: patch > > > > > > > > > > > > Automatic guessing of version by parsing package's upstream tarball > > > > name is wrong. It misses + and : and capital letters > > > > > > Not entirely. The first regex is the name of a debian source (see > > > sections 5.6.7) so no uppercase here. > > > > Oh OK. > > > > > The colon indicates epochs so I > > > don't think we want that one in a version number either. > > > > Policy explicitly allows versions with : if an epoch is in use. See > > section 5.6.12 > > As it does allow for a "-" if there's a debian revision. In this case > we'd have to make the regex dependent on the current version of the > debian package.
Well, - in upstream version nambers should be reasonably common in -rc -alpha or such. And your original regex allows it in orig but not in plain upstream. > > Did you actually encounter a package with a colon in the version number? > Otherwise I'd leave things as is (+ allowing for uppercase version > numbers and package names) and fix up the rests when we hit it. No, I haven't. But in case someone does, it will be less painful for him. Do you expect problems because of adding these extra characters to the regex? Saludos, Felipe Sateler
signature.asc
Description: This is a digitally signed message part.
