On Sun, 07 Jun 2009, Christian Perrier wrote:

> Quoting Jonathan Wiltshire (deb...@jwiltshire.org.uk):
> 
> > There's one other point I'd like your opinion on: changing this line:
> > 
> > - __Choices: Cups, DNS, Imap (Secure), Pop3 (Secure), SSH, Samba, Smtp, 
> > WWW, WWW (Secure)
> > + __Choices: cups, dns, imap (secure), pop3 (secure), ssh, samba, smtp, 
> > WWW, WWW (secure)
> > 
> > This affects your maintainer scripts though, which is why I haven't made
> > it yet. If you are happy to change it, the consistent case is desirable
> > but if it's a problem, it won't do any harm to leave it as is. Please
> 
> I'm personnally not in favor of the consistent case, here.
> 
> DNS, IMAP, POP, SSH, SMTP are protocol acronyms and should therefore
> be capitalized (you'll notice that this changes the maintainer scripts
> as well..:-))
> 
I was striving to use industry standard capitalization (eg DNS instead of
Dns or dns), and where there didn't seem to be consensus, I capitalized
the first letter. Looking at it more closely, I don't think I achieved this
with what is there though. I don't mind changing the maintainer script
if needed.

> WWW should maybe be replaced by HTTP
> 
> "Samba", if meant to relate to the communication protocol should be
> "CIFS", or maybe (because many people do not make the relation between
> Samba and CIFS) "CIFS (Samba)"
> 

Considering this, how about the following:
- __Choices: Cups, DNS, Imap (Secure), Pop3 (Secure), SSH, Samba, Smtp, WWW, 
WWW (Secure)
+ __Choices: CUPS, DNS, IMAP (secure), POP3 (secure), SSH, CIFS (Samba), SMTP, 
HTTP, HTTP (secure)

It is more consistent and something I think many configuring these services
would be accustomed to seeing.

Jamie

-- 
Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: Digital signature

Reply via email to