Quoting Jonathan Wiltshire (deb...@jwiltshire.org.uk): > Please ignore the patch I sent previously. I have made some mistakes > importing the Japanese translations and will send the correct versions > shortly. > > Sorry for the inconvenience (it's my first full review round ;)
Also, your patch still contains the trailing spaces I mentioned in a
previous answer:
> Template: strongswan/rsa_key_length
> Type: string
> Default: 2048
> -_Description: The length of the created RSA key (in bits):
> - Please enter the length of the created RSA key. It should not be less than
> - 1024 bits because this should be considered unsecure and you will probably
> - not need anything more than 2048 bits because it only slows the
> - authentication process down and is not needed at the moment.
> +_Description: RSA key length:
> + Please enter the length of RSA key you wish to generate. A value of less
> than
> + 1024 bits is not considered secure. A value of more than 2048 bits will
> + probably affect performance.
If afraid there are two problems in that chunuk...which I didn't
notice during the review.
Several lines end have a space at the end of the line:
> + Please enter the length of RSA key you wish to generate. A value of less
> than
^
> + 1024 bits is not considered secure. A value of more than 2048 bits will
^
(these ones and several others)
As I wrote already, fixing this in the templates.....will fuzzy
translations !
What I propose:
- once you fixed the Japanese translation import, send the patch
- I'll come on it, fix the spaces problem and then send a corrected
patch
- then the maintainer may apply it.
Alternatively, you can try, yourself, the unfuzzy method I proposed:
I suggest *not* correcting the extra spaces at the end of paragraphs
but correcting those at the end of lines. They are indeed meaning ful
and that will lead to double spaces in templates.
Unfortunately, that will break out translations as translators will
work on files where msgids have the double spaces.....so when you
merge the translations in after correcting the mistake and running
debconf-updatepo....those translations that were complete...will be
fuzzied.
They of course can be unfuzzied as the extra spaces obviously do not
affect translations. However, this has to be done very carefully: you
can't unfuzzy ALL PO files...but only those was have been updated
after the call for translations.
The right way to unfuzzy a PO file is:
msgattrib --clear-fuzzy foo.po >bar.po
Again, you should do this *only* on translations that were sent
complete.
When that happens (it happens also to me), I generally do this in my
private copy of the package tree as long as translations arrive in the
BTS....
....your call...:-)
signature.asc
Description: Digital signature
