tag 441184 - patch severity 441184 wishlist thanks > Above you will see the line that states I am now in a new working directory, > however the output of pwd immediately following svn-inject shows I am > not in that directory which leads me to believe that the call on line > 344 of svn-inject is not working properly. >
As stated by Hauke: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=441184#37 > the perl script ends and of course remains in the PWD of the > shell where it was invoked. You cannot change the working directory of a > parent process (the perl script is a sub-process of your shell). So, in > the last message "Your working directory is..." the "working directory" > doesn't mean PWD but the directory you can work with since there your > checkout (trunk) is to be found. We come across this problem in Emdebian a lot - the script can use chdir as much as you like, but if you call a script (of any kind) and then call a second script, the second script is called from the original working directory regardless of what the first script did with chdir or the equivalent. This is a shell issue, not a package issue. All the patch will do is tell you where the script is working, it cannot ensure that you end up in that directory at the end of the run. > Bottom line: we should consider checking if 'chdir $trunkdir' was really > executed before calling SDCommon::writeCfg but the user will always > remain in the directoy (s)he was when starting svn-whatever. Exactly. So I'm rejecting the patch and unsetting the patch tag on this bug, pending a check on the operation of chdir and a note in the manpage. -- Neil Williams ============= http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/
pgpXFZGNOLRw7.pgp
Description: PGP signature
