Re: your patch: you might want to pass something like "--quiltrc /dev/null" too, just for safety.
On Thu, May 07, 2009, Raphael Hertzog wrote: > I would welcome some more review. I chose to call dh_quilt_unpatch before > dh_clean because dh_clean should be the last command in charge on cleanup > of any cruft left. Thanks Raphael for pulling my attention on this bug; I don't mind calling unpatch just before dh_clean, but what's really important in my eyes is calling unpatch after make clean or make distclean (done by dh_auto_clean). This is required when for instance your need to patch the autotools files from your upstream and they don't use AM_MAINTAINER_MODE (you can't even patch it in: if you unpatch before clean it will trigger an autoreconf). I wouldn't mind unpatching after dh_clean either. (That's unrelated but I'm not a fan of dh_clean itself because I find it mixes cleanup of upstream cruft (e.g. .deps/*) and of debian/ files; also the default lists could accidentally match real upstream files, so I'd rather not have them.) -- Loïc Minier -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
