Hi there:
I tracked down this bug to the system(...) call to chmod.
Note that in Perl, system returns the return code from chmod, which in
the case of success is zero and nonzero on failure.
Thus you have to add: system(...) == 0 to the condition test, as
mentioned in `perldoc -f system'.
There is a patch below which should fix this issue for now.
Possible suggestions for the future (from rafl) is to use 'autodie',
which causes calls to open, close, system, etc to die automatically
upon failure, so that this sort of error checking isn't necessary. (As
well, you should probably check the return status of open, print, etc
to make sure they haven't failed. See PBP for guidelines on that.)
Cheers,
Jonathan
---
Index: svn-inject
===================================================================
--- svn-inject (revision 12861)
+++ svn-inject (working copy)
@@ -102,7 +102,7 @@
print O "#!/bin/sh\necho ok\n";
close O;
print "Checking if the default \$TMPDIR allows execution...\n" ;
- if (system ("chmod", "+x", "$testfile") and (`$testfile`) =~ /ok/ ) {
+ if (system ("chmod", "+x", "$testfile") == 0 and (`$testfile`) =~ /ok/ ) {
print "Default \$TMPDIR allows execution.\n"
} else {
print "Default \$TMPDIR does NOT allow execution.\n";
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
