Package: dak
Severity: critical
Hello,
I'm working on a dak setup, and caused some massive mailing to happen
because of this bug, unfortunaltely. My mail-whitelist file had only my
own address, and a blank line. The problem is that the blank line
apparently matched everything, so lots of people got mails =(.
The attached patch seems to fix it, though maybe there's a cleaner
solution you can think of.
Thanks,
--
Gustavo Noronha Silva <[email protected]>
Collabora Ltd.
diff --git a/daklib/utils.py b/daklib/utils.py
index 651e13a..2997b76 100755
--- a/daklib/utils.py
+++ b/daklib/utils.py
@@ -618,7 +618,7 @@ def send_mail (message, filename=""):
for line in whitelist_in:
if re_re_mark.match(line):
whitelist.append(re.compile(re_re_mark.sub("", line.strip(), 1)))
- else:
+ elif line.strip():
whitelist.append(re.compile(re.escape(line.strip())))
finally:
whitelist_in.close()
