Hi Raphaël, On Sat, Apr 25, 2009 at 09:02:11PM +0200, Raphael Hertzog wrote: > On Fri, 24 Apr 2009, Guido Günther wrote: > > > The SIGPIPE signal handler is not the default one when git-buildpackage > > > calls dpkg-buildpackage and this explains the failure because gunzip is > > > not killed by the signal as dpkg-source expect it. > > Python sets the signal handler to SIG_IGN which has caused trouble for > > others too (http://bugs.python.org/issue1652). > > And it was Colin Watson that fixed it ages ago in dpkg-source already, see > #89679. > > > > I don't know if python does it behind your back, or if git-buildpackage > > > does it on purpose but you should reset the signal handler before calling > > > dpkg-buildpackage. > > I have fixed this in git-buildpackage but am worried that every other > > python scripts that invokes dpkg-source has to be fixed as well. > > Wouldn't it make sense to set the correct signal mask on the child > > forked by dpkg-source to unzip the package? > > It was so once (see bug above) but it got lost in the rewrite and > Ian Jackson argued against this change (see > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=448667) and I think > that I'll stick to this decision for now unless Guillem has another > opinion. I think Ian has a good point here. Maybe failing if SIGPIPE isn't set to SIG_DFL is indeed a good options so we catch broken behaviour in an obvious way. Shall I file a wishlist bug? Cheers, -- Guido
-- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
