Hello, On Thu, Apr 23, 2009 at 12:24:19PM +0300, Tzafrir Cohen wrote: > This 'priv' field was removed to prevent direct access to it.
Well, actually the field has been phased out, and replaced with anonymous storage at the end of the structure, which makes it possible to have device specific structures in the netdev struct, which actually probably saves a tlb lookup to dereference priv :-). (something like that) Another problem was that priv wasn't at the end of the structure. > netdev_priv() should be used instead. The patch used the anonymous storage to create the old style void * functionality. The cleanest version is to actually put the vzaphfc devicestruct into the anonymous netdev struct. > There was a similar issue with wctc4xxp which is in the DAHDI tree: > http://bugs.digium.com/view.php?id=14285 > svn diff -c 5842 http://svn.digium.com/svn/dahdi/linux/trunk > svn diff -c 5848 http://svn.digium.com/svn/dahdi/linux/trunk Well, that's a cleaner way of my patch, but the solution is the same ;-). In the end it's just a workaround :-(. Regards, Ard -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in email? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
