Package: fai-client Version: 3.2.18 Severity: serious Tags: patch Justification: major component is broken
A small code re-arrangement in r5338 caused fai to skip the call to get-config-dir if the following return is taken (from task_confdir in subroutines-linux): 78 # check if monitor server is available 79 [ -z "$monserver" ] && monserver=$SERVER 80 if [ -z "$monserver" ]; then 81 echo "No monitor daemon defined." 82 return 83 fi As of r5338, get-config-dir is called in task_confdir, but _after_ these lines of code. Therefore it will never be called and no config space is fetched. Note that monserver will be empty on softupdates, dirinstalls or installs using a fixed IP configuration, unless set explicitly. Of course, softupdates without an updated config space are quite useless (note that there is _some_ config space available when using a storage other than NFS, its just not up-to-date). A bugfix for this issue is attached and also included in 3.2.18+experimental27. Best, Michael
2009-04-22 Michael Tautschnig <m...@debian.org>
* subroutines-linux: get-config-dir was never run if -z $monserver,
which may
be the case when no DHCP was done (dirinstall, softupdates, or
install using
fixed IP); problem was introduced by patch in r5338.
Index: trunk/lib/subroutines-linux
===================================================================
--- trunk.orig/lib/subroutines-linux
+++ trunk/lib/subroutines-linux
@@ -79,8 +79,8 @@
[ -z "$monserver" ] && monserver=$SERVER
if [ -z "$monserver" ]; then
echo "No monitor daemon defined."
- return
- fi
+ faimond=0
+ else
faimond=1
sendhostname=$HOSTNAME # save current hostname
if sendmon check; then
@@ -90,6 +90,7 @@
faimond=0
echo "Can't connect to monserver on $monserver port 4711. Monitoring
disabled."
fi
+ fi
get-config-dir || {
echo "Problems accessing the config space."
pgpxNjTE8uhn2.pgp
Description: PGP signature
