Bug#515843: virtual workspace problems with both -g and -G

[Troy Heber]

Here is a bit more information, when running with -d -D and changing
away from the current workspace and immediately change back causes the
main window to disappear for ~ 1 second and print the following:

13:56:23: Entering UNMAP
13:56:23: state=iconic previous=normal
13:56:23: withdrawing all windows
13:56:23: resetting prev_state
13:56:23: Entering UNMAP
13:56:23: state=iconic previous=iconic
13:56:23: repeating the same
13:56:25: Entering MAP
13:56:25: state=normal previous=iconic
13:56:25: Entering MAP
13:56:25: state=normal previous=iconic
13:56:25: running retile
13:56:25: Retiling windows
13:56:25: Not meant to be tiling; just reshow windows as they were
13:56:25: Sending console to front
13:56:25: Entering MAP
13:56:25: state=normal previous=mid-change
13:56:25: Entering MAP
13:56:25: dropping out as mid-change
13:56:25: Entering UNMAP
13:56:25: state=withdrawn previous=mid-change
13:56:25: dropping out as mid-change
13:56:25: Entering UNMAP
13:56:25: state=withdrawn previous=mid-change
13:56:25: dropping out as mid-change
13:56:26: Entering MAP
13:56:26: state=normal previous=mid-change
13:56:26: Entering MAP
13:56:26: dropping out as mid-change
13:56:26: done with retile
13:56:26: Entering MAP
13:56:26: state=normal previous=normal
13:56:26: Entering MAP
13:56:26: repeating the same
13:56:26: state=normal previous=normal

It looks like the problem is coming from capture_map_events() @
168824:

            if ( $config{internal_previous_state} eq "normal" ) {
                logmsg( 3, "withdrawing all windows" );
                foreach my $server ( reverse( keys(%servers) ) ) {
                    $xdisplay->req( 'UnmapWindow', $servers{$server}{wid} );
                    if ( $config{unmap_on_redraw} =~ /yes/i ) {
                        $xdisplay->req( 'UnmapWindow',
                            $servers{$server}{wid} );
                    }
                }
                $xdisplay->flush();
            }


If I make the if clause return unconditionally it resolve the problem
for me.  I'm not sure what the repercussions  of removing this code
block is but it seems to solve the issue for me. Hopefully this is
enough information to come up with a proper solution.

Thanks,

Troy

signature.asc
Description: Digital signature